Implement range selection with shift-click in the time panel #8870
+383
−171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
abey79
commented
Jan 30, 2025
Wumpf
approved these changes
Jan 30, 2025
| re_log.workspace = true | ||
| re_log_types.workspace = true |
There was a problem hiding this comment.
somewhat curious this needs log types actually and not just types_core, ah well...
There was a problem hiding this comment.
It was there already, was just reordered.
use re_log_types::{
ApplicationId, ComponentPath, EntityPath, ResolvedTimeRange, TimeInt, TimeReal, TimeType,
};
|
again, surprised this doesn't come with tests |
|
abey79
force-pushed
the
antoine/filt7-refactor-streams-tree
branch
from
a2417ae to
0c1eb2c
Compare
abey79
force-pushed
the
antoine/range-select-streams-tree
branch
from
931672e to
9e300eb
Compare
abey79
force-pushed
the
antoine/range-select-streams-tree
branch
from
9e300eb to
4b4ea81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Same as #8852 but in the streams tree.
This time, the visitor is slightly weird in that it enumerates the component on the fly instead of having them in the data structure. The reason for that is that this is costly and we don't want to always do it even if we dont needed (eg. when the tree is collapsed).
shift-click-streams.mp4